fix: v0.4 schema rules[] description names both normative specs#12
Merged
Conversation
The top-level rules description was copied verbatim from v0.3 and still pointed only at the v0.3 spec; the ruleEntry description already said v0.3/v0.4. Docs-only, no structural change. Caught by Copilot on the ds-mcp vendoring PR (ds-mcp#15). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the dspack v0.4 JSON schema’s top-level rules field description to correctly reference which specification versions define rule evaluation semantics, keeping the v0.4 schema text consistent with the capabilities introduced since v0.3.
Changes:
- Adjusts
rulesarray description to mention both v0.3 and v0.4 normative specifications.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "rules": { | ||
| "type": "array", | ||
| "description": "Machine-checkable governance rules, evaluated deterministically over dspack surface documents. Each rule is a typed, structured predicate plus a human-readable rationale. Evaluation semantics per type are normative in the v0.3 specification.", | ||
| "description": "Machine-checkable governance rules, evaluated deterministically over dspack surface documents. Each rule is a typed, structured predicate plus a human-readable rationale. Evaluation semantics per type are normative in the v0.3 specification (the three original types) and the v0.4 specification (required-props, forbiddenCategories).", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One string: the top-level
rulesdescription indspack.v0.4.schema.jsonwas copied verbatim from v0.3 and still said evaluation semantics are "normative in the v0.3 specification" — inconsistent with v0.4 addingrequired-propsandforbiddenCategories(theruleEntrydescription already says v0.3/v0.4). Docs-only, no structural change;npm run validategreen.Caught by Copilot reviewing the vendored copy on ds-mcp#15; that PR applies the identical string to the vendored copy so the two stay byte-equal.
🤖 Generated with Claude Code